feat: add constructor args example #2
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chadoh
added a commit
to AhaLabs/js-stellar-sdk
that referenced
this pull request
Oct 28, 2024
Uses new branch at stellar/soroban-test-examples#2
chadoh
force-pushed
the
feat/constructor_args
branch
from
5e5471e to
06ae7be
Compare
chadoh
force-pushed
the
feat/constructor_args
branch
2 times, most recently
from
83b68a6 to
c417a31
Compare
chadoh
added a commit
to AhaLabs/js-stellar-sdk
that referenced
this pull request
Nov 8, 2024
Uses new branch at stellar/soroban-test-examples#2
Copying in the example from https://github.com/stellar/stellar-cli/pull/1574/files#diff-0d743a0fa81fee10cf91dbf7fb7480daa248d14468d1cecfa24577ef00597f5b Also: - add a test for it - upgrade to p22 for whole workspace - gitignore test_snapshots We can circle back and use this repo as a submodule in the CLI once this is merged, as we do already in js-stellar-sdk.
chadoh
force-pushed
the
feat/constructor_args
branch
from
c417a31 to
d3b5f33
Compare
Shaptic
reviewed
Nov 12, 2024
rm constructor-args, it doesn't add much
Shaptic
reviewed
Nov 13, 2024
Shaptic
approved these changes
Nov 13, 2024
willemneal
approved these changes
Nov 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Copying in the example from https://github.com/stellar/stellar-cli/pull/1574/files#diff-0d743a0fa81fee10cf91dbf7fb7480daa248d14468d1cecfa24577ef00597f5b
Also:
We can circle back and use this repo as a submodule in the CLI once this is merged, as we do already in js-stellar-sdk.